Skip to content

Conversation

@karlb
Copy link

@karlb karlb commented Dec 8, 2025

We want to use Jovian's minBaseFee instead.

@karlb karlb force-pushed the karlb/remove-base-fee-floor branch from 005b359 to 68a9c39 Compare December 9, 2025 09:20
@karlb karlb force-pushed the karlb/remove-base-fee-floor branch from 68a9c39 to 4a463bb Compare January 7, 2026 09:20
@piersy
Copy link

piersy commented Jan 13, 2026

Hey @karlb looks like this PR got a bit mangled, maybe the base needs to be changed?

karlb added 2 commits January 14, 2026 10:13
We want to use Jovian's minBaseFee instead.
We default to Jovian in the configs, so that new tests will use Jovian.
@karlb karlb force-pushed the karlb/remove-base-fee-floor branch from 4a463bb to 36ef286 Compare January 14, 2026 09:13
@karlb karlb changed the base branch from karlb/rebase-15-20 to celo-rebase-15 January 14, 2026 09:14
@karlb
Copy link
Author

karlb commented Jan 14, 2026

Hey @karlb looks like this PR got a bit mangled, maybe the base needs to be changed?

Yes, that happens when it is stacked on another PR and that one gets merged via squash or rebase. A highly annoying part of github that I only stumbled across a dozen times this year. 😠 I've rebased it, so it looks clean again.

@palango
Copy link

palango commented Jan 14, 2026

How does the transition look? I assume with the given code it would be a step in the minimum base fee, which might lead to lots of rejected transactions.

@karlb
Copy link
Author

karlb commented Jan 14, 2026

How does the transition look? I assume with the given code it would be a step in the minimum base fee, which might lead to lots of rejected transactions.

Yes, it would be step greater than the usual maximum change between blocks. It would be nicer to increase it in small steps, but I don't see a really simple way to do it. And I don't think avoiding to drop a few txs is worth a much effort.

My preferred way would be to limit the minBaseFee change to the max change allowed per block, but that would be a deviation from upstream. I would only like to do that if upstream is likely to accept it.

@karlb karlb added this to the Jovian milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants