internal: Use a wrapper to detect server version #1074
+34
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
force-pushed
the
ceph-vers-detect-wrapper
branch
from
4197a06 to
9f31745
Compare
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
ceph-vers-detect-wrapper
branch
from
9f31745 to
136e051
Compare
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
ceph-vers-detect-wrapper
branch
from
136e051 to
c3f070b
Compare
anoopcs9
added
the
no-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have at least 3 occurrences where code is duplicated for detecting the underlying Ceph version as a string. Instead, we could have it in common and invoke the corresponding wrapper whenever required. Please note that there is this difference with this change, where we fetch and evaluate based on
CEPH_VERSIONenvironment variable each time in tests compared to one such step per test before.