rgw/restore: s3tests to test restore object functionality #599
Conversation
|
these tests can be added to teuthology cloud-transition test-suite itself. It needs to be updated to handle restore params . @shreyanshjain7174 please refer to d0ac12dc3864f92f452a38b722c5818e5c5d776f , f846f6ff020fb31baa1777c4e246abde62729ade to know what changes are needed in RGW test suites code. |
shreyanshjain7174
force-pushed
the
restore-s3tests
branch
3 times, most recently
from
1d413b8 to
f4e3463
Compare
shreyanshjain7174
force-pushed
the
restore-s3tests
branch
from
f4e3463 to
1174a6a
Compare
| assert response['ContentLength'] == len(data) | ||
|
|
||
| @pytest.mark.lifecycle_transition | ||
| @pytest.mark.cloud_transition |
There was a problem hiding this comment.
nit: could you mark these tests '@pytest.mark.cloud_restore' as well.
shreyanshjain7174
force-pushed
the
restore-s3tests
branch
2 times, most recently
from
ccc5228 to
5b946eb
Compare
s3tests_boto3/functional/test_s3.py
Outdated
| time.sleep(2 * (restore_interval + lc_interval)) | ||
|
|
||
| #verify object expired | ||
| verify_object(client, bucket, key, data, cloud_sc) |
There was a problem hiding this comment.
Just realized.. Does this check pass? Shouldn't data be empty here? for temporary restore since storage class wouldn't change, it may be better to check ContentLength ( '0') post expiration as well.
Same goes for read_through case too.
There was a problem hiding this comment.
done directly checking for the data now in read through and temporary restore both
This tests are added to tests temporary restore, permanent restore and read through resotre object functionality, this includes zonegroup parameters and checks. Signed-off-by: shreyanshjain7174 <[email protected]>
shreyanshjain7174
force-pushed
the
restore-s3tests
branch
from
5b946eb to
29ccf28
Compare
This tests are added to tests temporary restore, permanent restore and read through restore object functionality, this includes zonegroup parameters and checks.
Signed-off-by: shreyanshjain7174 [email protected]