This repository was archived by the owner on May 1, 2024. It is now read-only.
Customized id conversion to use getIdPart instead of getValue.#111
Closed
bashir2 wants to merge 1 commit intocerner:masterfrom
Closed
Customized id conversion to use getIdPart instead of getValue.#111bashir2 wants to merge 1 commit intocerner:masterfrom
bashir2 wants to merge 1 commit intocerner:masterfrom
Conversation
Author
|
@rbrush FYI |
6 tasks
Author
|
To close the loop here: It seems no one monitors PRs here anymore, so we went ahead and forked pieces of Bunsen that we depend on. A better fix for this issue can be found in this commit. So I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a proposed solution for Issue #106, i.e., change id conversion to only return the logical id (and not the full URL).
Additional Details
This is just one proposal (as I am not that familiar with Bunsen's code) but it seems to resolve our problem as shown in the updated test in this commit.
TODO (in case we want to go ahead with this solution):
Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.
Thanks for contributing to Bunsen.