Skip to content

Set on-release.yml to trigger on release publishing instead of push #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanleyyin
Copy link
Collaborator

@hanleyyin hanleyyin commented Jun 4, 2025

Issue # (if applicable)

N/A

Reason for this change

Previously, this workflow triggered on a push with any tag. This was causing a weird edge case where workflows that were triggered on a forked branch of the repository with a release cut to it would show up on the parent repo.

If we change this workflow to trigger instead on the actual publishing of a release, this behavior should stop.

Description of changes

The workflow only triggers when a release is published, instead of when a push with a tag happens.

https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=published#release

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Tested by:

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irbekrm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Previously, this workflow triggered on a push with any tag. This was
causing a weird edge case where workflows that were triggered on a
forked branch of the repository with a release cut to it would show up
on the parent repo.

If we change this workflow to trigger instead on the actual publishing
of a release, this behavior should stop.

Signed-off-by: HanleyYin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants