Skip to content

helm chart: support optional dnsConfig on deployment podspec #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stensonb
Copy link

@stensonb stensonb commented Jul 30, 2025

Issue # (if applicable)

n/a

Reason for this change

i'd like the option of passing dnsConfig to the chart to control this value in the deployment's podspec.

Description of changes

helm templating, default value of empty.

Describe any new or updated permissions being added

none

Description of how you validated changes

helm template . shows no changes

sample from k8s docs : https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config

helm template --set 'dnsConfig.options[0].name'=edns0 --set dnsConfig.searches='{ns1.svc.cluster-domain.example,my.dns.search.suffix}' . shows:

spec:
...
  template:
  ...
    spec:
    ...
      dnsConfig:
        options:
        - name: edns0
        searches:
        - ns1.svc.cluster-domain.example
        - my.dns.search.suffix
...

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant