Skip to content

[Helm] Support set image with digest #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Helm] Support set image with digest #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion charts/aws-pca-issuer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,24 @@ IfNotPresent
<td>image.tag</td>
<td>

Image tag
Image tag (used only when digest is empty)

</td>
<td>string</td>
<td>

```yaml
""
```

</td>
</tr>
<tr>

<td>image.digest</td>
<td>

Image digest (overrides tag when set). Example: sha256:aaaaaa...

</td>
<td>string</td>
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
image: "{{ .Values.image.repository }}{{- if .Values.image.digest }}@{{ .Values.image.digest }}{{- else }}:{{ .Values.image.tag | default .Chart.AppVersion }}{{- end }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command:
- /manager
Expand Down
5 changes: 3 additions & 2 deletions charts/aws-pca-issuer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ image:
repository: public.ecr.aws/k1n1h4h4/cert-manager-aws-privateca-issuer
# Image pull policy
pullPolicy: IfNotPresent
# Image tag
# Image tag (used only when digest is empty)
tag: ""

# Image digest (overrides tag when set). Example: sha256:aaaaaa...
digest: ""
# Disable waiting for CertificateRequests to be Approved before signing
disableApprovedCheck: false

Expand Down