Remove SetCertificateRequestConditionError #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
inteon
force-pushed
the
remove_SetCertificateRequestConditionError
branch
from
5564e5d to
7360a53
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
inteon
force-pushed
the
remove_SetCertificateRequestConditionError
branch
from
7360a53 to
33b083f
Compare
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
remove_SetCertificateRequestConditionError
branch
3 times, most recently
from
c906759 to
ee11618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning SetCertificateRequestConditionError, we now have 3 return values for the sign function.
Using the 2nd return value ExtraConditions, we can set any additional desired conditions on the CertificateRequest or CertificateSigningRequest resource.