Skip to content

Comments

Add image validation for Docker architecture#17

Closed
meyskens wants to merge 3 commits intocert-manager:masterfrom
meyskens:check-arch
Closed

Add image validation for Docker architecture#17
meyskens wants to merge 3 commits intocert-manager:masterfrom
meyskens:check-arch

Conversation

@meyskens
Copy link
Contributor

@meyskens meyskens commented Jun 12, 2020

This validates that the image arch found in the Docker images is the same as is meant to be.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 12, 2020
@jetstack-bot jetstack-bot requested a review from JoshVanL June 12, 2020 07:51
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2020
@meyskens meyskens mentioned this pull request Jun 12, 2020
Merged
munnerz
munnerz reviewed Jun 12, 2020
View reviewed changes
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2020
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: meyskens
To complete the pull request process, please assign sgtcodfish after the PR has been reviewed.
You can assign the PR to them by writing /assign @sgtcodfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

meyskens added 2 commits July 2, 2021 19:07
@meyskens @maelvls
Add image validation for Docker architecture
509d065 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens @maelvls
Add unit tests for tar validation
da8769e 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@maelvls
format imports
d154552 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
Copy link
Member

maelvls commented Jul 2, 2021

Nice! It looks clear and well tested!

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 8, 2021

@meyskens: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish
Copy link
Member

SgtCoDFish commented Aug 7, 2025

I think this is clearly rotten and I'll close!

@SgtCoDFish SgtCoDFish closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz munnerz left review comments

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@maelvls maelvls

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@meyskens @jetstack-bot @maelvls @SgtCoDFish @munnerz