No more requirement "be in the release folder" to run cmrel, remove the flag --cloudbuild #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
maelvls
force-pushed
the
embed-cloudbuild-files
branch
from
73f8c57 to
7f6411e
Compare
jetstack-bot
added
size/M
maelvls
changed the title
maelvls
force-pushed
the
embed-cloudbuild-files
branch
from
7f6411e to
95902dc
Compare
The flag --cloudbuild was thus removed. Signed-off-by: Maël Valais <[email protected]>
maelvls
force-pushed
the
embed-cloudbuild-files
branch
from
95902dc to
bf965bf
Compare
jetstack-bot
added
the
needs-rebase
|
@maelvls: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the team thinks, but I figured that it would be worth avoiding the dependency on being in the correct folder in order to run
cmrel. The cloudbuild files are now embedded into the binary. I thus removed the flag--cloudbuild.Note to the reviewer:
The downside to this approach is that we can't inspect the
cloudbuild.yamlfile for a givencmrelversion before submitting the build. Should I add a flag--dump-cloudbuildfor bothstageandpublishto remediate that?