Skip to content

Run 'make generate' on all go.mod updates #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Run 'make generate' on all go.mod updates #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions default.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,6 @@
],
dependencyDashboardApproval: true
},
{
matchManagers: [
'gomod',
],
postUpdateOptions: [
'gomodTidy',
],
},
{
// Set groupName to null to avoid this dependency from being included in the misc GHA group above.
groupName: null,
Expand All @@ -123,6 +115,7 @@
},
{
matchFileNames: [
'**/go.mod', // This will break all projects using this preset, but not makefile-module.
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states this will break projects not using makefile-modules, but the change is being implemented anyway. Consider either: 1) Creating a separate preset for makefile-modules projects, 2) Adding conditional logic to check for makefile presence, or 3) Updating the comment to explain the rationale for this breaking change and migration path for affected projects.

Suggested change
'**/go.mod', // This will break all projects using this preset, but not makefile-module.
'**/go.mod',
'**/Makefile', // Only run postUpgradeTasks if both go.mod and Makefile are present (proxy for makefile-modules usage).

Copilot uses AI. Check for mistakes.
'deploy/charts/**/values.yaml',
],
postUpgradeTasks: {
Expand Down