Skip to content

WIP: Add new Bundle (migration) controller #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikgb
Copy link
Member

@erikgb erikgb commented Aug 10, 2025

We need a new Bundle controller, as the current Bundle controller will be changed into the new ClusterBundle controller. The migration Bundle controller will:

  • If the ClusterBundle isn't managed by a user, the controller will create/update the ClusterBundle from the Bundle, and set an owner-reference back to the Bundle.
  • If the ClusterBundle is determined as user-managed, the controller will apply an empty patch to give up ownership over all previously owned fields. Including the owner-reference. From this point, the user is fully managing the ClusterBundle and the obsolete Bundle can be deleted.

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Aug 10, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 10, 2025
@erikgb erikgb force-pushed the new-bundle-controller branch 3 times, most recently from ec5089e to f296745 Compare August 18, 2025 18:43
@cert-manager-prow cert-manager-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 18, 2025
@erikgb erikgb force-pushed the new-bundle-controller branch 3 times, most recently from b580740 to 17ab91e Compare August 18, 2025 20:58
Signed-off-by: Erik Godding Boye <[email protected]>
@erikgb erikgb force-pushed the new-bundle-controller branch from 17ab91e to 4e6ed09 Compare August 19, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant