Fix variable error #78
Conversation
When using a GitOps deployment model, these resources are always considered "out of sync", as the resulting Certificate object's 'duration' field also specifies minutes & seconds. These changes are essentially a no-op, but match the object, for GitOps compatability.
fix: explicit pki durations to match resulting objects
This means that users don't have to configure the account ID explicitly. This code is inspired by the DNSimple provider in External-DNS.
- Add variable dnsimple.existingTokenSecret to the Helm chart to support using an existing secret. This is useful e.g. in combination with https://github.com/bitnami-labs/sealed-secrets. - Add variable dnsimple.tokenSecretName to support configuring the name of the token secret.
Add variable image.pullSecret to Helm chart to support specifying an image pull secret. This is mostly useful for people running an in-house fork of cert-manager-webhook-dnsimple.
feat: fetch account ID from DNSimple API
feat: add support for using an existing token secret
feat: add support for imagePullSecret
More verbosity during k8s test suite
…ert-manager-1.x fix(deps): update module github.com/cert-manager/cert-manager to v1.15.3
chore(deps): update ko-build/setup-ko action to v0.7
…ple-go-1.x fix(deps): update module github.com/dnsimple/dnsimple-go to v1.7.0
Change wording and handling of .Values.groupName
chore: Bump version to 0.1.4
* fix(deps): update module k8s.io/klog to v2 * Remove klog v1 * go mod tidy --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Valentin Klopfenstein <[email protected]>
Removed go template condition with legacy api version value and set it as a static value
Fix/remove legacy apiversions
Fix: remove legacy API versions
cert-manager-prow
bot
added
the
dco-signoff: no
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Pidu2. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cert-manager-prow
bot
added
needs-ok-to-test
No description provided.