Skip to content

cert-manager installation using argocd#1350

Closed
shahkv95 wants to merge 3 commits intocert-manager:masterfrom
shahkv95:cert-manager-argocd
Closed

cert-manager installation using argocd#1350
shahkv95 wants to merge 3 commits intocert-manager:masterfrom
shahkv95:cert-manager-argocd

Conversation

@shahkv95
Copy link

@shahkv95 shahkv95 commented Nov 25, 2023 •
edited by wallrj
Loading

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2023
@netlify
Copy link

netlify bot commented Nov 25, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 5098cdb
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6562d3ed3e098f00088d3cea
😎 Deploy Preview https://deploy-preview-1350--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shahkv95 shahkv95 mentioned this pull request Nov 25, 2023
Closed
jsoref
jsoref reviewed Nov 25, 2023
View reviewed changes
@shahkv95
Copy link
Author

shahkv95 commented Nov 26, 2023 •
edited
Loading

@jsoref @wallrj
have addressed and updated the PR with necessary changes in accordance with the comments.

Can you resolve the comments if you are good with it?
Thank you!

wallrj
wallrj requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shahkv95

This looks good. I left a few suggestions and enabled the automated tests.
There some spell check errors for which I have suggested some changes.

content/docs/installation/continuous-deployment-and-gitops.md
- Optional: A GitOps repository connected with ArgoCD: [setup guide](https://argo-cd.readthedocs.io/en/stable/user-guide/private-repositories/)

### Setting up cert-manager
1. Create an ArgoCD Application manifest file with the provided configuration to set up cert-manager.
Copy link
Member

@wallrj wallrj Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create an ArgoCD Application manifest file with the provided configuration to set up cert-manager.
1. Create an [ArgoCD Application manifest file](link-to-reference-documentation) with the provided configuration to set up cert-manager.

It will be useful to link to the documentation so that the reader can learn about the fields of this custom resource.

Copy link

@Tokynet Tokynet Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wallrj this is not my code/fix BUT i'm currently affected by this.
I will pull this branch and make the suggested edits after my comments below are accepted or better suggestions are made.

Copy link
Member

@wallrj wallrj Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't have permission to push to @shahkv95 's branch, so I've created my own.

content/docs/installation/continuous-deployment-and-gitops.md
- CreateNamespace=true
```
2. Commit the manifest file and sync the changes in ArgoCD. If a GitOps repository is not set up, use `kubectl apply -f <above-file-path>` to apply the manifest [installation guide for kubectl](https://kubernetes.io/docs/tasks/tools/#kubectl).
3. ArgoCD will synchronize the `DESIRED MANIFEST` and deploy cert-manager on Kubernetes based on the provided configuration.
Copy link
Member

@wallrj wallrj Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show the reader how they can check the status of the installation.
And explain what the reader should look for to know that the installation has succeeded.

@matthiashaasesourceforge
Copy link

matthiashaasesourceforge commented Feb 2, 2024

what's going on here ?
what's the status ?

@wallrj wallrj mentioned this pull request Mar 14, 2024
Open
@wallrj
Copy link
Member

wallrj commented Mar 14, 2024

@shahkv95 I don't have permission to push to your branch, so I've pushed your commits to my own branch, rebased and addressed my latest code review comments there:

I'll close this PR and we can continue the work there.

@wallrj wallrj closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj requested changes

+2 more reviewers

@Tokynet Tokynet Tokynet left review comments

@jsoref jsoref jsoref left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shahkv95 @jetstack-bot @matthiashaasesourceforge @wallrj @Tokynet @jsoref