-
Notifications
You must be signed in to change notification settings - Fork 378
Explain how to install cert-manager using ArgoCD #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wallrj
wants to merge
10
commits into
cert-manager:master
Choose a base branch
from
wallrj:cert-manager-argocd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4cd7029
cert-manager installation using argocd
shahkv95 adfe061
removed unnecessary configurations
shahkv95 ff060b8
formatting updates for installing cert-manager via argocd
shahkv95 115ae0b
Whitespace cleanup
wallrj 9d47842
Fix spell check errors
wallrj 07aae2e
Link to ArgoCD Application documentation
wallrj 8b7f4ae
Suggest an application filename
wallrj 475248d
Use latest version in examples
wallrj 756756c
Fix spelling of cert-manager
wallrj a59bfa7
Consistent spelling of OutOfSync
wallrj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This still has to be verified
Normally by using ServerSideApply and ServerSide diffing, there should be no issues with mutating webhooks:
This change is based on https://argo-cd.readthedocs.io/en/stable/user-guide/diff-strategies/ and https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#server-side-apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I tested with this manifest
but I am still seeing a
metadata.generationdiff (I first tried without theignoreDifferencesandrespectIgnoreDifferencesbut that still results in matchExpressions diff.