Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented May 7, 2025

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2025
@netlify
Copy link

netlify bot commented May 7, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 19c5f89
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/681b8ad87ee53e000886dd49
😎 Deploy Preview https://deploy-preview-1686--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jsoref
Copy link
Contributor Author

jsoref commented May 8, 2025

/assign wallrj

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running ./scripts/generate on this branch, but it doesn't seem to have made the intended difference to the whitespace in the rendered api docs:

$ git diff
diff --git i/content/docs/reference/api-docs.md w/content/docs/reference/api-docs.md
index 84ecf376..b34c2d74 100644
--- i/content/docs/reference/api-docs.md
+++ w/content/docs/reference/api-docs.md
@@ -1136,7 +1136,7 @@ description: >-
         <code>imagePullSecrets</code>
         <br />
         <em>
-          <a href="https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/">[]Kubernetes core/v1.LocalObjectReference</a>
+          <a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#localobjectreference-v1-core">[]Kubernetes core/v1.LocalObjectReference</a>
         </em>
       </td>
       <td>
@@ -1261,7 +1261,7 @@ description: >-
               <code>imagePullSecrets</code>
               <br />
               <em>
-                <a href="https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/">[]Kubernetes core/v1.LocalObjectReference</a>
+                <a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#localobjectreference-v1-core">[]Kubernetes core/v1.LocalObjectReference</a>
               </em>
             </td>
             <td>
@@ -7135,5 +7135,5 @@ description: >-
 </table>
 <hr />
 <p>
-  <em> Generated with <code>gen-crd-api-reference-docs</code> on git commit <code>4562b9a</code>. </em>
+  <em> Generated with <code>gen-crd-api-reference-docs</code> on git commit <code>f3ffb86</code>. </em>
 </p>

There must be something else going on.
Maybe it's the post-processing script which prettifies the HTML:

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wallrj. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsoref
Copy link
Contributor Author

jsoref commented May 8, 2025

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants