-
Notifications
You must be signed in to change notification settings - Fork 378
docs: harmonize <p> formatting by dropping internal spaces
#1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
jsoref
commented
May 7, 2025
- Docs 1679 follow-up #1685 (comment)
Signed-off-by: Josh Soref <[email protected]>
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign wallrj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running ./scripts/generate on this branch, but it doesn't seem to have made the intended difference to the whitespace in the rendered api docs:
$ git diff
diff --git i/content/docs/reference/api-docs.md w/content/docs/reference/api-docs.md
index 84ecf376..b34c2d74 100644
--- i/content/docs/reference/api-docs.md
+++ w/content/docs/reference/api-docs.md
@@ -1136,7 +1136,7 @@ description: >-
<code>imagePullSecrets</code>
<br />
<em>
- <a href="https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/">[]Kubernetes core/v1.LocalObjectReference</a>
+ <a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#localobjectreference-v1-core">[]Kubernetes core/v1.LocalObjectReference</a>
</em>
</td>
<td>
@@ -1261,7 +1261,7 @@ description: >-
<code>imagePullSecrets</code>
<br />
<em>
- <a href="https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/">[]Kubernetes core/v1.LocalObjectReference</a>
+ <a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#localobjectreference-v1-core">[]Kubernetes core/v1.LocalObjectReference</a>
</em>
</td>
<td>
@@ -7135,5 +7135,5 @@ description: >-
</table>
<hr />
<p>
- <em> Generated with <code>gen-crd-api-reference-docs</code> on git commit <code>4562b9a</code>. </em>
+ <em> Generated with <code>gen-crd-api-reference-docs</code> on git commit <code>f3ffb86</code>. </em>
</p>
There must be something else going on.
Maybe it's the post-processing script which prettifies the HTML:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
😢 |