-
Notifications
You must be signed in to change notification settings - Fork 378
Update NetworkPolicy guidelines to reflect the correct namespace #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: László Csupity <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects inaccurate documentation about where cert-manager creates acmesolver resources for ACME HTTP01 challenges. The documentation previously incorrectly stated that these resources are created in the cert-manager namespace when using a ClusterIssuer.
- Updated the description of where acmesolver resources are created during ACME HTTP01 challenges
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cert-manager will deploy an `acmesolver` Pod, a Service and an Ingress (or Gateway API) resource | ||
| in the namespace of the Issuer | ||
| or in the cert-manager namespace if it is a ClusterIssuer. | ||
| in the namespace of the Challenge resource. |
Copilot
AI
Nov 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] While technically correct, 'in the namespace of the Challenge resource' is somewhat circular. Consider clarifying this to 'in the same namespace as the Certificate resource' since Challenge resources are created in the same namespace as their parent Certificate, which is more immediately useful information for users planning network policies.
| in the namespace of the Challenge resource. | |
| in the same namespace as the Certificate resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this change would make it more clear, because the Certificate resource is not necessarily created by the user (Ingress, Gateway, etc.) or it may not even be created, if directly using CertificateRequest. I think the Challenge is the most appropriate for this documentation.
Fix the misleading statement about namespaces for the HTTP01 solver pods.
The solver pods are always created in the namespace of the Challange resource (which is in the namespace of the Ingress/Certificate)
This can be verified in the code: https://github.com/cert-manager/cert-manager/blob/master/pkg/issuer/acme/http/pod.go#L180