Skip to content

Add network requirements for 'metrics server' to 'webhook, cainjector' for 1.16+ versions #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Add network requirements for 'metrics server' to 'webhook, cainjector' for 1.16+ versions #1836

merged 1 commit into from
Nov 6, 2025

Conversation

@lunarwhite
Copy link
Member

@lunarwhite lunarwhite commented Nov 6, 2025 •
edited
Loading

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2025
@netlify
Copy link

netlify bot commented Nov 6, 2025 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9bdc5ae
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/690c7aaab55dee0008ce9f57
😎 Deploy Preview https://deploy-preview-1836--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@erikgb erikgb requested a review from Copilot November 6, 2025 09:36
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation to reflect that all three cert-manager components (controller, webhook, and cainjector) expose metrics servers on port 9402, not just the controller.

  • Expanded metrics server documentation to include webhook and cainjector components
  • Updated network policy guidance to cover all three services
  • Applied changes consistently across all version documentation (v1.16, v1.17, v1.18, and current)

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
content/docs/installation/best-practice.md Updated metrics server documentation to include webhook and cainjector alongside controller
content/v1.18-docs/installation/best-practice.md Applied same metrics server documentation update for v1.18
content/v1.17-docs/installation/best-practice.md Applied same metrics server documentation update for v1.17
content/v1.16-docs/installation/best-practice.md Applied same metrics server documentation update for v1.16

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wallrj
Copy link
Member

wallrj commented Nov 6, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj, wallrj-cyberark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@cert-manager-prow cert-manager-prow bot merged commit 45563b3 into cert-manager:master Nov 6, 2025
7 checks passed
@lunarwhite lunarwhite deleted the np-patch branch November 6, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wallrj-cyberark wallrj-cyberark wallrj-cyberark approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lunarwhite @wallrj @wallrj-cyberark