Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Nov 11, 2025

This PR migrates all (remaining) Helm installation/upgrade docs to use the OCI chart repositories.

Relates to cert-manager/community#43: To provide non-CyberArk employee maintainers full release capabilities, we have decided to migrate our official Helm installation method to the OCI chart repositories.

After this is merged, I will create additional PRs to update the release process documentation as agreed in our weekly development meeting.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2025
@netlify
Copy link

netlify bot commented Nov 11, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9b83df
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6913beab7d81db0008013c94
😎 Deploy Preview https://deploy-preview-1842--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@erikgb erikgb requested a review from Copilot November 11, 2025 22:48
Copilot finished reviewing on behalf of erikgb November 11, 2025 22:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates Helm installation documentation from the legacy HTTP chart repository (https://charts.jetstack.io) to OCI-based chart repositories (oci://quay.io/jetstack/charts), enabling non-CyberArk maintainers to have full release capabilities.

Key Changes:

  • Replace all jetstack/cert-manager chart references with oci://quay.io/jetstack/charts/cert-manager
  • Remove helm repo add commands as they're not needed for OCI registries
  • Add new documentation section explaining the legacy repository migration path

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
content/docs/usage/kube-csr.md Update cert-manager installation to use OCI repository
content/docs/usage/istio-csr/installation.md Migrate cert-manager and istio-csr Helm installations to OCI, remove repo add commands
content/docs/usage/gateway.md Update cert-manager upgrade command to use OCI repository
content/docs/usage/csi-driver/installation.md Migrate csi-driver installation to OCI, remove repo add command
content/docs/usage/csi-driver-spiffe/installation.md Update cert-manager and csi-driver-spiffe installations to use OCI, remove repo add command
content/docs/usage/csi-driver-spiffe/README.md Update csi-driver-spiffe installation example to use OCI repository
content/docs/tutorials/zerossl/zerossl.md Update cert-manager installation to use OCI repository
content/docs/tutorials/getting-started-aws-letsencrypt/README.md Migrate cert-manager installation to OCI, remove inline repo flag
content/docs/tutorials/getting-started-aks-letsencrypt/README.md Update cert-manager install and upgrade commands to use OCI, remove repo add command
content/docs/tutorials/certificate-defaults/README.md Migrate cert-manager installation to OCI, remove inline repo flag
content/docs/tutorials/acme/migrating-from-kube-lego.md Update cert-manager upgrade command to use OCI repository
content/docs/trust/trust-manager/installation.md Migrate cert-manager and trust-manager installations to OCI, remove repo add command
content/docs/trust/trust-manager/README.md Update cert-manager and trust-manager installations to use OCI, remove repo add command
content/docs/troubleshooting/webhook.md Migrate cert-manager installations to OCI, update hardcoded version to use variable
content/docs/policy/approval/approver-policy/installation.md Migrate cert-manager and approver-policy installations to OCI, remove repo add command
content/docs/installation/upgrade.md Add new section documenting legacy repository upgrade path, update primary upgrade commands to use OCI
content/docs/installation/compatibility.md Update cert-manager installation to use OCI repository
content/docs/contributing/policy.md Update Chart.yaml dependency example to use OCI repository
content/docs/configuration/acme/http01/README.md Update cert-manager upgrade command to use OCI repository

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Erik Godding Boye <[email protected]>
@erikgb erikgb requested a review from Copilot November 11, 2025 22:54
Copilot finished reviewing on behalf of erikgb November 11, 2025 22:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikgb erikgb requested review from SgtCoDFish and maelvls November 11, 2025 22:57
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I haven't forensically looked to check that every reference is replaced, but this is a definite improvement as is and it looks thorough - thank you so much!

Will this allow us to close cert-manager/community#43 ?

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@cert-manager-prow cert-manager-prow bot merged commit 37dbaaf into cert-manager:master Nov 12, 2025
13 checks passed
@erikgb
Copy link
Member Author

erikgb commented Nov 12, 2025

Will this allow us to close cert-manager/community#43 ?

@SgtCoDFish, it will almost close the issue, but I want to update our release documentation before closing it.

@erikgb
Copy link
Member Author

erikgb commented Nov 12, 2025

I haven't forensically looked to check that every reference is replaced, but this is a definite improvement as is and it looks thorough - thank you so much!

There is still a reference to the legacy Helm chart in the Flux tutorial. It required some more rewriting to be valid, so I decided to postpone it to a follow-up PR, which I will try to create shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants