Feature enable querying alerts by multiple keys #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `notified` from alerts.json fixture * Fixed bug in charts.py * Moved alert query logic to Alert model * Enabled query by multiple keys via the alert_api endpoint * Added serialize method to Alert object for uniform dictionary representation of alerts
(high, low and medium) and integers (1-8)
ManofWax
approved these changes
Jul 30, 2025
This was
linked to
issues
Jul 30, 2025
Lorygold
approved these changes
Jul 31, 2025
|
@Noble-47 this PR is still draft or it can be merged? |
|
It can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues #379 and #380, along with other related bug fixes and improvements:
notifiedfield fromalerts.jsonfixturecharts.pyaffecting data renderingAlertmodel for better separation of concernsalert_apiendpointserializemethod to theAlertmodel for consistent dictionary representation