Refactor Django Views Tests to use setUpTestData for Performance Improvement

[Itz-Agasta]

closes #369

Refactored Django test classes to use setUpTestData() instead of setUp() for database object creation, following Django's official testing best practices for improved performance.

Changes Made

Files Modified:

1. test_views.py (Primary target)
2. buffalogs/impossible_travel/tests/alerting/test_alert_googlechat.py (Demonstration)

Key Refactoring:

• Before: Database objects created in setUp() method (runs before every test)
• After: Database objects moved to @classmethod setUpTestData() (runs once per test class)
• Maintained: Per-test setup (like Client() instantiation) remains in setUp()

Performance Impact (test_views.py)

Metric	Before (setUp)	After (setUpTestData)	Improvement
Test execution time	~0.30s	~0.25s	17% faster
Total runtime	~1.8s	~1.7s	6% faster
Database operations	195 objects (15×13)	15 objects (1×15)	92% reduction

Testing & Validation

• ✅ All 13 tests in test_views.py pass
• ✅ All 4 tests in test_alert_googlechat.py pass
• ✅ Test isolation maintained (no shared state issues)
• ✅ Performance improvements verified with timing measurements

This implementation follows the Django Testing Documentation guidelines:

"If you need to create objects in setUpTestData, you should use cls to reference them throughout the test class rather than creating objects in setUp()."

[Itz-Agasta]

hi @Lorygold I have refactored 2 test files to use setUpTestData instead of setUp for database object creation:

• test_views.py
• test_alert_googlechat.py

All tests are passing and performance has improved.

Could you please review these changes? If everything looks good, I will continue refactoring the remaining test files that still use setUp. Thank you!

[Lorygold]

Hi @Itz-Agasta, black linter failed (black . --check --diff --config ${GITHUB_WORKSPACE}/.github/configurations/python_linters/.black)
Please check the CONTRIBUTING.md file to run flake8, black and isort linters manually for passing CI tests

[Lorygold]

The related issue of this PR has been opened to refactor just the Views test (other issues and PRs have been opened in order to refactor other methods), so the changes to test_alerter_* are not required in this task (conflicts indeed)

[Lorygold]

This function is not needed, Django should already provide the default self.client instance in TestCase and APITestCase → documentation here