Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sites became redundant with Winter'19 #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remote sites became redundant with Winter'19 #224

wants to merge 1 commit into from

Conversation

rsoesemann
Copy link
Contributor

With Winter'19 remote site setting for Metadata API calls from Apex are not needed anymore https://releasenotes.docs.salesforce.com/en-us/winter19/release-notes/rn_apex_streamline_api_calls.htm

I just replace the URL creation code. Someone also might want to remove the Remote site helper files.

With Winter'19 remote site setting for Metadata API calls from Apex are not needed anymore https://releasenotes.docs.salesforce.com/en-us/winter19/release-notes/rn_apex_streamline_api_calls.htm

I just replace the URL creation code. Someone also might want to remove the Remote site helper files.
@afawcett
Copy link
Contributor

Thanks for this @rsoesemann, looks good. We should update the docs a bit more to say that in most cases you are now correct, thankfully not needed! However for orgs without my domain enabled its still needed, hopefully this will become more of a corner case as time goes by though. 👍

@afawcett
Copy link
Contributor

afawcett commented Nov 23, 2018

Anyway, this change looks good to me! 👍 cc @stephenwillcock @agarciaodeian

@rsoesemann
Copy link
Contributor Author

I was a bit shocked today that this is still not merged in.

@jakubmplatek
Copy link

It seems that URL.getSalesforceBaseUrl().toExternalForm() works without the RSS as well
Are they planning to deprecate it in favour of getOrgDomainUrl() ?

@rsoesemann
Copy link
Contributor Author

@jakubmplatek Can't confirm what you are saying. I used the current state of the repo yesterday and it still fail due to a missing RSS. Only when I changed to the new getOrgDomainUrl() it worked. Or do you mean switching version number is sufficient.

@jakubmplatek
Copy link

jakubmplatek commented May 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants