v44 update, reduce MetadataService file size, support non-virtual types #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) attempt to generate a smaller MetadataService class (see details below) 3) Support for nested inheritance and non-virtual types 4) Misc updates, PMD cleanup, adding squirly braces, etc. in an effort to create a smaller class file (and stay under the 1mb limit): * use 'NS' instead of 'SOAP_M_URI' for the static variable name, saves 8 bytes per use * use tabs instead of spaces * replaced some more instances where the namespace URL was used (such as in the _info array) put static final variables at top of class that specify 'MetadataServiceImported' and 'MetadataService' classes so it is easier to change if needed
|
Hmm, the diff in github isn't great. It looks like a lot more change than there really is. If you ignore differences in whitespace, it actually looks a lot cleaner. Let me know if I did this right, or if I need to make changes and re-submit. |
dbtavernerffdc
approved these changes
Jul 15, 2019
|
@rmccu I've approved but this code doesn't deploy for me. It looks like MetadataServiceExamples and MetadataServiceTest both need updating to reflect the changed types. Also I'm not sure why Metadata.Picklist no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in an effort to create a smaller class file (and stay under the 1mb limit):
put static final variables at top of class that specify 'MetadataServiceImported' and 'MetadataService' classes so it is easier to change if needed