Skip to content

sql output: handle empty string fields paramter #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebix merged 1 commit into from
Jan 21, 2025
Merged

sql output: handle empty string fields paramter #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
- The requirement can only be installed on Python version < 3.12.
- Add a check on the Python version and exit if incompatible.
- Add a deprecation warning (PR#2544 by Sebastian Wagner)
- `intelmq.bots.outputs.sql.output`:
- Treat an empty string `fields` parameter as unset parameter, fixing a crash in default configuration (PR#2548 by Sebastian Wagner, fixes #2548).

### Documentation

Expand Down
4 changes: 1 addition & 3 deletions intelmq/bots/outputs/sql/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ def init(self):
def process(self):
event = self.receive_message().to_dict(jsondict_as_string=self.jsondict_as_string)

key_names = self.fields
if key_names is None:
key_names = event.keys()
key_names = self.fields or event.keys()
valid_keys = [key for key in key_names if key in event]
keys = '", "'.join(valid_keys)
values = self.prepare_values(itemgetter_tuple(*valid_keys)(event))
Expand Down
Loading