Fix type inconsistency in sql #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search results, various updates for Idea fields
Add a smoke test for the home page
Remove voter field from forms, add migrations
Do some CSS work and add listing voting
Add notifications when installed in collab
IN-462 - Add challenge text
…brown-custom_comments Conflicts: src/idea/templates/idea/detail.html
Conflicts: src/idea/static/idea/css/idea.css src/idea/templates/idea/detail.html
Add mptt to buildout
Fix fontawesome icon for Read More link in IE
Tests now run when bundled with collab
Add private room capability
Add optional anonymity for private rooms
README changes: IdeaBox is not hypenated. Django is capitalized
Update taggit info in README
|
1be6da6 is the important commit; everything else is merging in the |
|
Can we get some more background on this? My understanding based on the branch name and commit message is the old style doesn't quite work right for postgresql, but apparently works fine in mysql and sqlite? It doesn't look like we have any tests for comment_count or recent_activity... perhaps it'd make sense to add those to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #90 generically by casting strings as ints in the queries.