Upgrade datahub #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the DataHub integration by updating import paths, revising API signatures, and bumping the package version.
- Updated import paths for Kafka source configuration and reports in both tests and source files
- Modified the API of get_schema_metadata to include a new boolean parameter
- Increased the package version from 2.0.1 to 2.1.0 in setup.py
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/apicurio/test_schema_registry.py | Adjusted import paths and updated tests to pass an explicit boolean argument to get_schema_metadata |
| src/apicurio_kafka/apicurio_schema_registry.py | Updated import paths and modified get_schema_metadata() signature; added stub methods for subject-related functionality |
| setup.py | Bumped version number to 2.1.0 |
Comments suppressed due to low confidence (1)
tests/apicurio/test_schema_registry.py:122
- Consider adding a unit test that covers the scenario when the 'is_subject' parameter is true, to ensure that both code paths are properly tested.
schema_metadata = apicurio_schema_registry.get_schema_metadata("test", "", False)
|
|
||
| def get_schema_metadata( | ||
| self, topic: str, platform_urn: str | ||
| self, topic: str, platform_urn: str, is_subject: bool |
There was a problem hiding this comment.
Please update the docstring for get_schema_metadata to clearly document the purpose and expected usage of the new 'is_subject' parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.