bugfix(otgfs): Fixes a couple issue with OTGFS #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracted all the common USB code that will be shared between otgfs and usbhs
Transfer flag could be cleared when it is not the end point expected. This would be a problem under spurious wakeup.
Dummyc0m
approved these changes
Nov 1, 2024
| let res = if status.mask_uis_endp() == 0 { | ||
| match status.mask_token() { | ||
| if status.mask_uis_endp() == 0 { | ||
| let res = match status.mask_token() { | ||
| UsbToken::OUT => { | ||
| if regs.rx_len().read().0 != 0 { | ||
| error!("Expected 0 len OUT stage, found non-zero len, aborting"); |
There was a problem hiding this comment.
v.set_r_tog(true) a few lines down is not necessary.
| regs.uep_rx_ctrl(i).write(|v| v.set_mask_r_res(EpRxResponse::NAK)); | ||
| regs.uep_tx_ctrl(i).write(|v| v.set_mask_t_res(EpTxResponse::NAK)); | ||
| self.endpoint_set_enabled(EndpointAddress::from_parts(i, Direction::In), false); |
Endpoints should be disabled on bus reset. According to datasheet it
looks like the UEPx_y_MOD.{RX_EN,TX_EN} should have reset value of 0 but
clearly they are reset to 1 which case our endpoints to be "enabled" by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change address mainly 2 concerns regarding the OTGFS driver
endpoint_set_enablefunction be lost. This is caused by the hardware behaving differently than what the manual describes.Beside the two bugfix, it also lays the groundwork for USBHS by extracting some of the common code into the
usbmodule.