Skip to content

Update torch & torchvision to support RTX 50 series #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025

Conversation

LlamaEnjoyer
Copy link
Contributor

Torch updated to 2.7.0 and vision to 0.22.0.

joeyballentine
joeyballentine previously approved these changes May 8, 2025
@joeyballentine
Copy link
Member

Looks like this introduced some type issues. Are you able to handle fixing these?

@LlamaEnjoyer
Copy link
Contributor Author

I'll give it a try tomorrow

Update pyright to 1.1.400
@LlamaEnjoyer
Copy link
Contributor Author

@joeyballentine I updated pyright to most recent version, since 1.1.338 is ancient. I'm hoping this will resolve the problem.

@joeyballentine
Copy link
Member

It did not. You're gonna have to fix those type issues (or if you don't know how, I can do it for you if i end up having some time)

Attempt to fix type issues
Revert pyright update
@LlamaEnjoyer
Copy link
Contributor Author

Allright, one last attempt. The classic "works for me" moment. If that doesn't do the trick then I rest my case and pass the torch you :)

@LlamaEnjoyer
Copy link
Contributor Author

LlamaEnjoyer commented May 15, 2025

Well at least it something different this time

Edit: ignore that, I'm stupid - didn't revert the pyright to the correct version

This time reverted to the correct original version
@geomax22
Copy link

Not sure how this works but when is a compiled version of chaiNNer with RTX 50 support likely to be available (a nightly build?)
Thanks

@LlamaEnjoyer
Copy link
Contributor Author

Not sure how this works but when is a compiled version of chaiNNer with RTX 50 support likely to be available (a nightly build?) Thanks

It requires approval from @joeyballentine

@joeyballentine
Copy link
Member

Whoops, will merge

@joeyballentine joeyballentine merged commit f76a45d into chaiNNer-org:main May 30, 2025
14 checks passed
clausqr pushed a commit to clausqr/chaiNNer that referenced this pull request Jun 25, 2025
* Update torch & torchvision to support RTX 50 series

* Update requirements.txt

Update pyright to 1.1.400

* Update convert_to_onnx_impl.py

Attempt to fix type issues

* Update requirements.txt

Revert pyright update

* Update requirements.txt

This time reverted to the correct original version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants