[feat] add all option in contacts #1399
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thunnini
reviewed
Mar 19, 2025
| @@ -264,6 +278,31 @@ export class RecipientConfig | |||
| setValue(value: string): void { | |||
| this._value = value; | |||
|
|
|||
| if (this._option?.enableNameserviceWhenPrefixEntered) { | |||
There was a problem hiding this comment.
솔직히 실행은 안시켜봤지만 enableNameserviceWhenPrefixEntered 구현에서 이 부분에서 처리했을때 문제가 예상되는게 recipientConfig의 value와 name service들의 value가 sync가 맞아야 하는데 이렇게 구현했을때 예를들어 dogemos.cosmos를 유저가 입력했다가 마지막 글자를 지워서 dogemos.cosmo로 바꿨을때 name service랑 sync가 안맞게 되지 않을까 싶습니다.
확실하게 하려면 좀 귀찮지만 enableNameserviceWhenPrefixEntered 옵션을 각각의 name service implementation에 다 넣어서 처리해야할 듯합니다. 그리고 setValue에서 처리하는게 아니라 nameSerivce.result getter에서 처리하거나 해야할듯한데 이 부분은 좀 더 봐야할듯 합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현사항