pipelines: test: add emptypackage #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add emptypackage pipeline test, copied from other melange package repos. Signed-off-by: Arturo Borrero Gonzalez <[email protected]>
smoser
reviewed
Aug 9, 2025
| echo "FAIL: Expected this package [$pkg] to be empty, but it isn't:" >& | ||
| echo "$file_list" >&2 | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
I know it might seem like overkill, but can you follow the pattern of other tests, that have pipeline that just calls a program delivered in a package?
ie, take a look at #130 . If you want to put your metapackage and virtualpackage into the same "package-type-checks" package and expose its use under different pipelines I'm ok with that too.
One benefit of putting the body of the script into a package is that it will get shellcheck run on it.
This was referenced Aug 15, 2025
Member
|
working on that #159 |
Contributor
|
@debasishbsws , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add emptypackage pipeline test, copied from other melange package repos.