chore: Add crane pipeline that checks image environment #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be used to compare values for variables we set across our packages to ensure there is not drift between pinned dependencies in our packaging and in upstream images There are a lot of images that intentionally ship pinned dependencies. A number of those images also declare the version of those dependencies within the image's environment. This is commonly seen across AI/ML images Limited to assessing env vars for now Signed-off-by: RJ Sampson <[email protected]>
jonjohnsonjr
reviewed
Nov 5, 2025
| log := clog.FromContext(ctx) | ||
|
|
||
| // Get image config with crane | ||
| configJSON, err := crane.Config(image, crane.WithContext(ctx)) |
There was a problem hiding this comment.
This will always be checking the amd64 image by default, which we might be okay with? We could plumb an arch flag down to this as well in case we want to check the arm64 variant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be used to compare values for variables we set across our packages to ensure there is not drift between pinned dependencies in our packaging and in upstream images
There are a lot of images that intentionally ship pinned dependencies. A number of those images also declare the version of those dependencies within the image's environment. This is commonly seen across AI/ML images
Limited to assessing env vars for now