feat(help-check,ver-check): use package name as default binary name#337
Closed
sanghanan wants to merge 2 commits intochainguard-dev:mainfrom
Closed
feat(help-check,ver-check): use package name as default binary name#337sanghanan wants to merge 2 commits intochainguard-dev:mainfrom
sanghanan wants to merge 2 commits intochainguard-dev:mainfrom
Conversation
If no binary is specified in the inputs to help-check and ver-check pipelines, use the package name as the binary instead. This would be convenient when we're building packages with single binaries.
sanghanan
changed the title
Contributor
Author
|
@kranurag7 that would definitely be more convenient, let me make that change, thanks! |
EyeCantCU
reviewed
Feb 27, 2026
Member
EyeCantCU
left a comment
EyeCantCU
left a comment
There was a problem hiding this comment.
Thank you for working on this! With the number of package variants and version streams we support though, I'd prefer we didn't merge for consistency there, as I wouldn't expect those variants and streams to also have variants and streams in the bin names
Contributor
Author
|
@EyeCantCU, appreciate the insight! I was considering it mainly for simple packages, but I understand how keeping it explicit would be better for consistency. Will go ahead and close this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no binary is specified in the inputs to help-check and ver-check pipelines, use the package name as the binary instead. This would be just a tiny bit convenient when we're building packages with single binaries. It lets us do: