package-type-check: support C++ header extensions in dev package check#340
Open
toabctl wants to merge 1 commit intochainguard-dev:mainfrom
Open
package-type-check: support C++ header extensions in dev package check#340toabctl wants to merge 1 commit intochainguard-dev:mainfrom
toabctl wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
HasHeaderFiles only checked for .h files, causing false failures for C++ dev packages that only ship .hpp, .hxx, .hh, or .h++ headers (e.g., boost, tl-expected, toml11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HasHeaderFilesonly checked for.hfiles, causing false failures for C++ dev packages that only ship.hpp,.hxx,.hh, or.h++headers (e.g., boost, tl-expected, toml11)isHeaderFile()helper that checks all standard C/C++ header extensionsTest plan
go test ./pkg/utils/ -run TestIsHeaderFile -v— all 12 cases pass