Skip to content

Conversation

@yebai
Copy link
Member

@yebai yebai commented Nov 17, 2025

No description provided.

@yebai yebai removed their assignment Nov 17, 2025
@yebai yebai marked this pull request as draft November 17, 2025 22:38
@github-actions
Copy link
Contributor

Mooncake.jl documentation for PR #856 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR856/

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────────┬─────────┬─────────────┬────────┐
│                      Label │   Primal │ Mooncake │ MooncakeFwd │  Zygote │ ReverseDiff │ Enzyme │
│                     String │   String │   String │      String │  String │      String │ String │
├────────────────────────────┼──────────┼──────────┼─────────────┼─────────┼─────────────┼────────┤
│                   sum_1000 │ 110.0 ns │     1.91 │        1.92 │    1.09 │        5.19 │   10.2 │
│                  _sum_1000 │ 951.0 ns │     6.81 │        1.01 │  1840.0 │        38.8 │   1.09 │
│               sum_sin_1000 │  6.55 μs │     2.54 │        1.39 │    1.78 │        11.2 │   1.92 │
│              _sum_sin_1000 │  5.28 μs │     3.02 │         2.2 │   307.0 │        13.4 │    2.5 │
│                   kron_sum │ 487.0 μs │     6.34 │         2.7 │    6.01 │       145.0 │   9.51 │
│              kron_view_sum │ 420.0 μs │      8.1 │        4.57 │    17.8 │       179.0 │   5.63 │
│      naive_map_sin_cos_exp │  2.15 μs │     2.56 │        1.45 │ missing │        7.18 │   2.32 │
│            map_sin_cos_exp │  2.13 μs │     2.88 │        1.51 │    1.67 │        6.13 │   2.93 │
│      broadcast_sin_cos_exp │  2.29 μs │     2.46 │        1.43 │    3.91 │        1.45 │   2.21 │
│                 simple_mlp │ 438.0 μs │     4.56 │        2.92 │     1.6 │        6.78 │   3.27 │
│                     gp_lml │ 587.0 μs │     4.33 │        1.56 │    2.23 │     missing │   4.86 │
│ turing_broadcast_benchmark │  1.93 ms │     4.19 │        3.18 │ missing │        25.0 │   2.08 │
│         large_single_block │ 391.0 ns │     4.46 │         2.0 │  4680.0 │        31.4 │    2.2 │
└────────────────────────────┴──────────┴──────────┴─────────────┴─────────┴─────────────┴────────┘

@Technici4n
Copy link
Collaborator

I don't think that nightly is worth it, but we should add pre once it's available.

@penelopeysm
Copy link
Collaborator

I agree, nightly is quite fragile. BTW, current nightly is 1.14.

Signed-off-by: Hong Ge <[email protected]>
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/interpreter/ir_utils.jl 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Hong Ge <[email protected]>
@Technici4n
Copy link
Collaborator

Note that pre is currently julia 1.12. Do we know when the first 1.13 pre will be released?

@penelopeysm
Copy link
Collaborator

Yeahhh, it's kind of in an awkward spot, that's why I haven't added 1.13 tests for the Turing repos. I'm not actually sure how to specify 1.13 in CI. Maybe version: '1.13-nightly' might work (following from https://github.com/julia-actions/setup-julia?tab=readme-ov-file#julia-versions) but I've never tried it.

1.13.0-alpha1 was supposed to be released last week, but it didn't build: https://julialang.slack.com/archives/C7E3LFG82/p1763643474697259

@penelopeysm
Copy link
Collaborator

penelopeysm commented Dec 2, 2025

1.13-alpha2 is released, so might be worth checking whether pre resolves to 1.13

yebai and others added 5 commits December 2, 2025 21:48
* Use conditional for interpreter selection based on version

Signed-off-by: Hong Ge <[email protected]>

* Add conditional inclusion for patch_for_319.jl

Conditionally include patch_for_319.jl for versions below 1.12

Signed-off-by: Hong Ge <[email protected]>

* Refactor local_interp initialization for version check

Signed-off-by: Hong Ge <[email protected]>

* Apply suggestions from code review

Signed-off-by: Hong Ge <[email protected]>

---------

Signed-off-by: Hong Ge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants