Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expand the readme #2740

Merged
merged 18 commits into from
Nov 21, 2023
Merged

feat: Expand the readme #2740

merged 18 commits into from
Nov 21, 2023

Conversation

alexlokshin-czi
Copy link
Contributor

@alexlokshin-czi alexlokshin-czi commented Nov 17, 2023 •
edited by github-actions bot
Loading

CCIE-2086
Summary Create a readme for Happy repo
Type Task Task
Status In Review

CCIE-2086

hspitzley-czi
hspitzley-czi reviewed Nov 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@alexlokshin-czi alexlokshin-czi marked this pull request as ready for review November 20, 2023 19:45
@alexlokshin-czi alexlokshin-czi requested a review from a team as a code owner November 20, 2023 19:45
netvisao
netvisao suggested changes Nov 20, 2023
View reviewed changes
Copy link

@netvisao netvisao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include a tutorial for a developer using happy?

The config file, the repo needed before issuing happy commands, happy commands everyone needs to know etc.?

@alexlokshin-czi
Copy link
Contributor Author

Can we also include a tutorial for a developer using happy?

The config file, the repo needed before issuing happy commands, happy commands everyone needs to know etc.?

We can, but the intention was to put it here: https://chanzuckerberg.github.io/happy/

netvisao
netvisao reviewed Nov 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
jakeyheath
jakeyheath reviewed Nov 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
@jakeyheath jakeyheath self-requested a review November 21, 2023 15:38
@alexlokshin-czi alexlokshin-czi enabled auto-merge (squash) November 21, 2023 18:07
@alexlokshin-czi alexlokshin-czi merged commit 10ede86 into main Nov 21, 2023
@alexlokshin-czi alexlokshin-czi deleted the alokshin/readme branch November 21, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeyheath jakeyheath jakeyheath approved these changes

@netvisao netvisao netvisao approved these changes

@hspitzley-czi hspitzley-czi hspitzley-czi approved these changes

@dspadea dspadea Awaiting requested review from dspadea

@naihsuanshao naihsuanshao Awaiting requested review from naihsuanshao

@cyberious cyberious Awaiting requested review from cyberious

@dtsai-czi dtsai-czi Awaiting requested review from dtsai-czi

@abiju-czi abiju-czi Awaiting requested review from abiju-czi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexlokshin-czi @netvisao @jakeyheath @hspitzley-czi