Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use span instead of print log_key directly #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Oct 14, 2022

Signed-off-by: STRRL [email protected]

changes:

  • create span for serve_https
  • use span! with log_keyt instead of logging it directly

ref: #39 (comment)

@Andrewmatilde Andrewmatilde added the need test Need reviewer's own test. label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test Need reviewer's own test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants