Skip to content

Mortar ALE Assembler #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Mortar ALE Assembler #1597

wants to merge 33 commits into from

Conversation

brunaccampos
Copy link
Collaborator

@brunaccampos brunaccampos commented Jul 28, 2025

Description

This PR adds a mortar Arbitrary Lagrangian Eulerian (ALE) asssembler to allow the simulation of rotor-stator transient problems.

Testing

An application test of a transient Taylor-Couette with mortar has been added.

Documentation

The documentation has been updated to include both rotor rotation angle and rotor angular velocity in the mortar section parameters.

Miscellaneous (will be removed when merged)

The MortarManagerBase and MortarManagerCircle functions have been updated regarding the order of the parameters in the constructor, as well as allowing the parameters radius and n_subdivisions to be public. This was needed so that the values obtained by calling compute_n_subdivisions_and_radius can be stored in the class parameters, and so that such parameters can be accessed by the reinit_mortar function incluided in scratch data.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@brunaccampos brunaccampos added Enhancement New feature or request Ready for review labels Jul 28, 2025
@brunaccampos brunaccampos requested review from peterrum and blaisb July 28, 2025 17:59
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few comments, otherwise nice

@blaisb blaisb self-requested a review July 30, 2025 17:54
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment regarding this solution transfer and things will be good :)

Comment on lines +123 to +126
/// Number of cells at the interface between inner and outer domains
unsigned int n_subdivisions;
/// Radius at the interface between inner and outer domains
double radius;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is temporal?

@@ -1266,6 +1247,37 @@ NavierStokesBase<dim, VectorType, DofsType>::refine_mesh_uniform()
this->update_multiphysics_time_average_solution();
}

template <int dim, typename VectorType, typename DofsType>
void
NavierStokesBase<dim, VectorType, DofsType>::transfer_without_refinement()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? If we rotate the mesh, the vectors do not changes. So there is no need for transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants