Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plots #122

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

Update plots #122

wants to merge 6 commits into from

Conversation

ferenckata
Copy link
Collaborator

  • rewriting IQwidth plot to facets
  • rewriting reverse cumulative plots to facets
  • fix minor bug with if-else check order
  • what is the intended behaviour when is.null(fitInRange) is true in plotReverseCumulatives? now it just raises a warning and does not plot

@charles-plessy
Copy link
Owner

Hi Katalin, yes the test on fitInRange is there to allow plotting the reverse cumulatives when the slopes were not completed. A plot is made by default, and if fitInRange is not null, the fitting information is overlayed. Finally the graph is output p + facet_wrap(group). Your pull request removes that possibility, but I would like to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-plessy charles-plessy Awaiting requested review from charles-plessy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferenckata @charles-plessy