feat(viewport): add AppendContent and DeleteTopContent methods#431
Draft
ThisGuyCodes wants to merge 2 commits intocharmbracelet:masterfrom
Draft
feat(viewport): add AppendContent and DeleteTopContent methods#431ThisGuyCodes wants to merge 2 commits intocharmbracelet:masterfrom
ThisGuyCodes wants to merge 2 commits intocharmbracelet:masterfrom
Conversation
|
Just wanted to chime in and say I have the same use case. Hope this gets approved |
caarlos0
changed the title
caarlos0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where I want to stream logs to a bubbletea-based TUI, which seems like a perfect use of the
viewport.Model! Particularly since logs can sometimes come at you quite fast, using the terminal built-in scrolling mechanisms seems prudent.However the current
viewport.Modelonly supports fully replacing the current content and re-syncing on every change.Here I've added two methods to
viewport.Model:AppendContent: adds to the end of the current content, and returns a tea.Cmd that "scrolls" the new content into view if necessary (i.e. ifPastBottom()andHighPerformanceRenderingis true).DeleteTopContent: deletesnlines from the top of the current content, and scrolls appropriately if this leaves you "passed the top".Open to feedback on everything here! I'll get around to making a few test apps myself to verify behavior before taking this out of draft.