-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viewport): gutter column, soft wrap, search highlight #697
Open
caarlos0
wants to merge
40
commits into
feature/i236-viewport-horizontal-scroll
Choose a base branch
from
columnsign
base: feature/i236-viewport-horizontal-scroll
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+668
−103
Open
Changes from 6 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
2f4a36a
feat(viewport): column sign
caarlos0 ea26eb7
feat: gutter, soft wrap
caarlos0 6c10dc2
wip: search
caarlos0 4eebb08
wip: search
caarlos0 eb50edc
wip: search
caarlos0 7784024
fix: perf
caarlos0 303ded7
fix: rename
caarlos0 619bac5
wip
caarlos0 d1ff1ab
wip
caarlos0 fbf76e8
refactor: viewport highlight ranges
caarlos0 5880b3a
fix: ligloss update
caarlos0 8e14bd2
doc: godoc
caarlos0 7f6d0eb
feat: fill height optional
caarlos0 8ddb856
fix: handle no content
caarlos0 0c86665
fix: empty lines
caarlos0 2d53a61
feat(viewport): horizontal scroll (#240)
tty2 e1944c4
Merge remote-tracking branch 'origin/master' into columnsign
caarlos0 b5f1251
wip
caarlos0 933f181
wip
caarlos0 0e3e31b
Revert "wip"
caarlos0 a7dc5f8
Reapply "wip"
caarlos0 d1928be
fix: wide
caarlos0 28cd0ad
fix: wide, find
caarlos0 067e70a
still not quite there
caarlos0 2a3bb65
fix: grapheme width
caarlos0 7b96ddd
fix: cleanups
caarlos0 912d216
fix: refactors, improves highlight visibility
caarlos0 7d13ae0
docs: godoc
caarlos0 87a4e45
docs: additional bubbles (#583)
caarlos0 e3ce11a
docs: update charm & friends blurb (#703)
bashbunni 7ab08fb
fix(viewport): scroll to last line when borders (#706)
caarlos0 1bdd4c6
fix: stopwatch.Start() (#707)
bevicted 0632e23
Merge remote-tracking branch 'origin/master' into columnsign
caarlos0 06eda29
chore: lipgloss update
caarlos0 b66bc64
chore: x/ansi update
caarlos0 74c65d3
fix: typos, godocs
caarlos0 4ac5ac9
fix: rename
caarlos0 3d06ce4
fix: typo
caarlos0 01cca44
fix: scroll when soft-wrapping
caarlos0 afe305c
fix: soft wrap adjustments
caarlos0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should def remember to remove this before merging 😄