fix(list): Add Width to HelpStyle to fix incorrect list width behavior when filtering
#760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Width() to HelpStyle to ensure the help text rendering does not exceed list's width causing behavior seen in bug charmbracelet#744
kalyncoose
changed the title
HelpStyle to fix incorrect list width behavior when filtering
kalyncoose
changed the title
HelpStyle to fix incorrect list width behavior when filteringWidth to HelpStyle to fix incorrect list width behavior when filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Width()toHelpStyleto ensure the help text rendering does not exceed list's widthTesting Notes
myList.Styles.HelpStyle = myList.Styles.HelpStyle.Width(48)which confirmed the help text as root cause for the behaviorre: discord help thread
Fixes #744