(v2) proposal(filepicker): allow configuring FS #776
+80
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #759 which would allow to use an FS in v1 without breaking change. |
|
@dolmen I think my changes are backwards compatible and can be cherry picked. However, I did not add symlink resolution, which could be a problem. |
|
Could you edit the description of the PR to remove the stuff that is irrelevant (Help, Filter...)? Make it fully focused on what the code delivers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current functionality of the file picker is limited. It would be great to have
This PR includes a proposal for the last list item. The idea is to expose an FS property which by default uses the default os filesystem but it can be changed to a different value. It seemed that this won't require a method, but I might be wrong about this.
It is a really rough attempt so please let me know how I could improve on this.