feat(key): accept both key.Text and key.String for key matches #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the key matching logic to accept both the key.Text and key.String representations of keys. This allows for more flexible key matching, especially when dealing with different keyboard layouts or input methods. Fixes: charmbracelet/bubbletea#1390
caarlos0
approved these changes
Apr 17, 2025
|
worth adding a test maybe? |
aymanbagabas
force-pushed
the
v2-easier-keymatch
branch
from
6c1a0b8 to
8b901d5
Compare
|
@aymanbagabas, is this still needed after charmbracelet/bubbletea#1399? If so, let's close this. If not, let's update accordingly and get this merged. |
This would make |
aymanbagabas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the key matching logic to accept both the key.Text and key.String representations of keys. This allows for more flexible key matching, especially when dealing with different keyboard layouts or input methods.
Fixes: charmbracelet/bubbletea#1390