V2 exp #853
Draft
V2 exp #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the API and removes high performance rendering and its related methods from the viewport package. It changes the API and makes the methods return nothing instead of lines to render.
This removes all the `NewModel` functions from all the bubbles and any deprecated fields and types.
(v2) refactor!: viewport: remove deprecated HighPerformanceRendering
(v2) refactor!: remove deprecated references
This also adds an Option type for arguments to New()
…rval() This also adds an Option type for arguments to New()
chore: merge `master` with #601 into `v2-exp`
* Fix virtual cursor blinking * Use getter and setter for styles * Use getter and setter for virtual-real cursor management
This commit exposes the MoveToBegin and MoveToEnd methods in the textarea package, allowing users to programmatically move the cursor to the beginning or end of the input text.
* fix!(textarea): send focus status to promptFunc * feat(filepicker): add highlighted file path * chore: rename and add docs * fix(filepicker): disabled cursor style * feat(textarea): promptFunc receives a PromptInfo type with metadata --------- Co-authored-by: Kujtim Hoxha <[email protected]>
* feat(textarea): get the word under the cursor * fix: lint * Update textarea/textarea_test.go Co-authored-by: Copilot <[email protected]> * test: fix Signed-off-by: Carlos Alexandro Becker <[email protected]> --------- Signed-off-by: Carlos Alexandro Becker <[email protected]> Co-authored-by: Copilot <[email protected]>
This ensures that the viewport content is set and persisted correctly. Setting the content during View won't doesn't work because it mutates a copy of the model instead without persisting the changes. Moreover, any after effects of setting the content won't be visible because the next Update will be called on the older model, not the new one.
fix(textarea): ensure viewport content is set during update
Signed-off-by: Liam Stanley <[email protected]>
Signed-off-by: Liam Stanley <[email protected]>
Signed-off-by: Liam Stanley <[email protected]>
…831) (#837) Co-authored-by: Christian Rocha <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.