Skip to content

fix: enable reasoning for o1 model #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable reasoning for o1 model #85

wants to merge 1 commit into from

Conversation

@Peteskiis
Copy link

@Peteskiis Peteskiis commented Oct 16, 2025 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • I have created a discussion that was approved by a maintainer (for new features).

@Peteskiis Peteskiis requested a review from a team as a code owner October 16, 2025 20:47
@Peteskiis Peteskiis requested review from kujtimiihoxha and raphamorim and removed request for a team October 16, 2025 20:47
caarlos0
caarlos0 requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the openrouter.json file is auto generated - are you sure you didn't mean to change openai.json?

in any case, seems like openrouter reports o1 without reasoning 🤔

@Peteskiis
Copy link
Author

Peteskiis commented Oct 17, 2025

yeah, the issue was from openrouter. I updated openai.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caarlos0 caarlos0 caarlos0 requested changes

@raphamorim raphamorim Awaiting requested review from raphamorim raphamorim is a code owner automatically assigned from charmbracelet/everyone

@kujtimiihoxha kujtimiihoxha Awaiting requested review from kujtimiihoxha kujtimiihoxha is a code owner automatically assigned from charmbracelet/everyone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Peteskiis @caarlos0