fix: make prompt optional (#54) #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunsworld
force-pushed
the
make_prompt_optional
branch
from
1c80164 to
abffd06
Compare
Author
|
rebased to v0.2.0 and removed merge conflicts due to change in error handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.When there are no historical messages it makes sense for generation to error when prompt is empty. Also, I believe it makes sense when there are associated files.
However, when there are historical messages, it should be OK to not require a prompt.
This use-case comes up when we're trying to generate from an existing conversation where the last step was the result of a tool call outside of the fantasy framework. This came up during AG-UI support where there is the context of front-end and remote tools with the front-end tool executed on the browser and control then handed over to the agent.