-
Notifications
You must be signed in to change notification settings - Fork 67
feat(#89): added input file as window title #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlejandroSuero
wants to merge
26
commits into
charmbracelet:main
Choose a base branch
from
AlejandroSuero:feature/show-filename-when-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
808ac7a
feat(#89): added input file as window title
AlejandroSuero fbc39f8
fix: removed else statment when fatal
AlejandroSuero 8e465d7
feat(svg): center text and improved error message
AlejandroSuero 09a8bf8
feat(configurations): added `title: auto` to `full.json`
AlejandroSuero 0ec729a
feat(config): modified `config.Title` to be a string
AlejandroSuero 822f84c
feat(interactive): modified to work with `config.Title` as string
AlejandroSuero 32641ce
feat(main): modified to work with `config.Title` as string
AlejandroSuero 095d65c
test(window.title): test suite for `--window.title`
AlejandroSuero 3cd9296
docs: updated `README.md` with new usage of `config.Title` as string
AlejandroSuero 03aff1a
feat(svg): early return
AlejandroSuero ad05ab8
feat(golden): modified images when `make golden`
AlejandroSuero 0c51a1c
docs(README): better demo and better warning
AlejandroSuero c087cce
test(freeze): using `t.Cleanup` and checking for child elements
AlejandroSuero 8d2ab0a
feat(main): use `} else if {`
AlejandroSuero 014f87d
feat: added title position and title text
AlejandroSuero de16e84
feat: added title position logic
AlejandroSuero 716540c
feat: added title positions
AlejandroSuero 89fb933
test(golden): `make golden` after changes
AlejandroSuero 9341f16
refactor(title): moved from `svg.go` to `main.go`
AlejandroSuero af731cf
docs: updated `--title` usage
AlejandroSuero a2ba0f3
fix: removed `group:"Window"` from `Title`
AlejandroSuero 406de92
refactor: switch and value usage
AlejandroSuero 11b73ac
refactor: use constants for positions
AlejandroSuero 7a46616
feat: increase font size a bit and improved center with controls
AlejandroSuero bb40c9b
fix: simply return err
AlejandroSuero 244c20c
Merge branch 'main' into feature/show-filename-when-controls
AlejandroSuero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.