Add a soft wrap option to handle Lines and ShowLineNumbers behavior #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hazegard
force-pushed
the
soft_wrap
branch
2 times, most recently
from
af350e3 to
b428d1c
Compare
This commit introduces a `SoftWrap` option that adjusts the behavior of the `Lines` option and `ShowLineNumbers` when used with the `Wrap` option. - `Lines`: Currently, when both `Lines` and `Wrap` options are used, the line count is computed after wrapping occurs. This can lead to discrepancies where wrapped lines count as multiple lines, causing the final output to exclude some original input lines. With the new `SoftWrap` option, wrapped lines will count as a single line, ensuring that all lines specified in the `Lines` option are correctly included. - `ShowLineNumbers`: When `SoftWrap` is enabled, line numbers are not added to wrapped lines. This preserves the original line numbering, ensuring consistency with the input file.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
SoftWrapoption that adjusts the behavior of theLinesandShowLineNumbersoptions when used with theWrapoption.Lines:Currently, when both
LinesandWrapoptions are used, the line count is computed after wrapping occurs. This can lead to discrepancies where wrapped lines count as multiple lines, causing the final output to exclude some original input lines.With the new
SoftWrapoption, wrapped lines will count as a single line, ensuring that all lines specified in theLinesoption are correctly included.ShowLineNumbers:When
SoftWrapis enabled, line numbers are not added to wrapped lines. This preserves the original line numbering, ensuring consistency with the input file.Here is an example showing the behavior when softwrap is used and when softwrap is not used :
freeze -w 80 --lines 17,50 --show-line-numbers config.gofreeze --soft-wrap -w 80 --lines 17,50 --show-line-numbers config.go