fix: load system fonts for CJK and non-ASCII character support #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for loading system fonts when converting SVG to PNG, which fixes the issue where CJK and other non-ASCII characters are not rendered correctly in PNG output. Changes: - Add platform-specific font directory definitions using build tags: - dirs_darwin.go: macOS system font directories - dirs_linux.go: Linux system font directories - dirs_windows.go: Windows system font directories - dirs_other.go: fallback for unsupported platforms - Modify png.go to load fonts from system directories - Add FREEZE_NO_SYSTEM_FONTS=1 env var to skip system font loading - Warn when font directories fail to load (visible at default log level) - Handle os.UserHomeDir() errors properly Performance note: Font directories are scanned on each conversion. For better performance, set FREEZE_NO_SYSTEM_FONTS=1, use SVG output, or install rsvg-convert. Fixes charmbracelet#93 Related to charmbracelet#83
Wangnov
requested review from
meowgorithm and
tauraamui
and removed request for
a team
|
I tried your patch but this didn't work for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for loading system fonts when converting SVG to PNG, fixing the issue where CJK (Chinese, Japanese, Korean) and other non-ASCII characters are not rendered correctly in PNG output.
Changes
dirs_darwin.go: macOS system font directoriesdirs_linux.go: Linux system font directoriesdirs_windows.go: Windows system font directoriesdirs_other.go: fallback for unsupported platformspng.goto load fonts from system directoriesFREEZE_NO_SYSTEM_FONTS=1env var to skip system font loading for performanceos.UserHomeDir()errors properly to avoid relative path issuesPerformance Note
Font directories are scanned on each conversion. For better performance:
FREEZE_NO_SYSTEM_FONTS=1to disable system font loadingrsvg-convert(which handles fonts natively)Testing
Related Issues
Fixes #93
Related to #83 (this PR follows the maintainer suggestion to use build tags instead of runtime checks)