Skip to content

Conversation

isabelroses
Copy link
Contributor

closes #44

@Delta456
Copy link

Should also close #76

@isabelroses
Copy link
Contributor Author

Example outputs

ex1

ex2

@maaslalani
Copy link
Contributor

Hey @isabelroses, this is an awesome PR:

I think it would benefit from a few changes:

  1. Let's prefix the option with --execute. so it's logically grouped with the execute functionality.

  2. I think it can be on by default, what do you think? i.e. opt-out --execute.command=false (maybe --execute.show-command?)

  3. Change the prompt to > to match VHS, we use:

PS1=\\[\\e[38;2;90;86;224m\\]> \\[\\e[0m\\]

@isabelroses
Copy link
Contributor Author

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up shifted
out2
test

@isabelroses
Copy link
Contributor Author

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up

Realised this might be because since the start of this PR I installed libsvg.

@maaslalani
Copy link
Contributor

freeze

@maaslalani
Copy link
Contributor

I believe it could be because of the font, since it's not a monospace font, it looks like.

@isabelroses
Copy link
Contributor Author

I believe it could be because of the font, since it's not a monospace font, it looks like.

Ahh good call this is on WSL.

@4zv4l
Copy link

4zv4l commented May 27, 2024

Hi, any update on this ? Do we know when it would be merged ?

@bashbunni bashbunni requested a review from a team as a code owner March 26, 2025 16:28
@bashbunni bashbunni requested review from bashbunni and removed request for a team March 26, 2025 16:28
@bashbunni
Copy link
Contributor

Added VHS-styled cursor, still need to sort out styling the shell command with chroma. For example, the screenshot below should show the unstyled ANSI sequence that I provided in the command (echo '\x1b[1;31mHello')

execute-command-ansi

@caarlos0 caarlos0 added the enhancement New feature or request label Mar 26, 2025
@bashbunni
Copy link
Contributor

bashbunni commented Mar 28, 2025

run in test:

execute-command-ansi

run locally:
hello

Ideally we get the command looking like the local run with the output looking like it does in the test output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: plot the command along with the result

6 participants